Fix: Awaiting Response Category - #144
Merged
Merged
Conversation
Awaiting Response Category has been fully broken since #140
BenHall-1
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Awaiting Response Category has been fully broken since #140.
That release added an in-process category update publisher, but it was written on a branch predating the Kafka→Redis migration and still published to
tickets.rpc.categoryupdate. The only listener is onstream:rpc:categoryupdate, so every message went to a stream with no consumer group.ProduceSyncXADDs to any name and auto-creates the stream, so this failed silently — no error, no warning, no log.CategoryUpdateQueue.GetReadyForUpdateis aDELETE ... RETURNING, so reading consumes.The publisher's 30s eligibility window meant rows were deleted at age 30s and never survived to the 10m window
category-update-producerpolls with — so that service saw an empty queue on every run. Not a race: deterministically 0%.Both directions were affected, into the awaiting category and back out.
Changes
tickets.rpc.categoryupdate→stream:rpc:categoryupdate.CategoryUpdateStreamand registered the listener with it, so publisher and consumer can no longer drift.Remove the
category-update-producerservice — the worker now owns the queue, and two pollers on a destructive read steal rows from each other.Once
XLEN tickets.rpc.categoryupdatestops increasing,DELit. Do not replay: those messages reference deleted rows and stale statuses.Retiring that service also drops two bugs it had — clearing a panel's awaiting category stranded tickets in it, and a category of
0produced a no-op PATCH that still consumed a rate-limit token. The worker'scategoryForStatushandles both.Type of Change
Testing
Awaiting Response Category should work again
Checklist